Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added backend for the Codebadge project #54

Closed

Conversation

ayushnagar123
Copy link
Member

@ayushnagar123 ayushnagar123 commented Jun 6, 2020

Problem

Github Issue Number: #53 #51

PR includes:

  • login
  • signup
  • fetching user details
  • fetching organization details
  • fetching organization members
  • Codebadge bot fetching all events through webhook

Type of Change

  • Bug fix
  • New Feature
  • Development of UI/UX prototypes
  • Small refactor
  • Change in Documentation

Checklist

  • My code follows the same style as the codebase
  • My Code change requires a change in documentation
  • I have updated the Readme accordingly
  • I made PR against development branch
  • I have run the test cases locally and it's passing.
  • I have squashed my commits

@ayushnagar123 ayushnagar123 changed the title Added backedn for the Codebadge project Added backend for the Codebadge project Jun 6, 2020
@jaskiratsingh2000
Copy link
Member

jaskiratsingh2000 commented Jun 6, 2020 via email

@ayushnagar123 ayushnagar123 self-assigned this Jun 10, 2020
@ayushnagar123 ayushnagar123 added the new feature A new feature on which work is yet to begin label Jun 10, 2020
@devesh-verma
Copy link
Member

  1. @ayushnagar123 Going ahead I would like to see PRs more often. It's hard to review 92file changes in 1PR. Also, it's not preferred keeping in consideration the commit history and progress of the project.
  2. Make 1PR per functionality.
  3. Also, work on your commit messages.
  4. Squash your commits.

TL;DR
I am okay reviewing more PRs rather than reviewing 1PR with so much of work.

@ayushnagar123
Copy link
Member Author

Surely i will take care of it next time thanks for the inputs.

@ayushnagar123
Copy link
Member Author

I have updated and created a new pull request #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature A new feature on which work is yet to begin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants