feat(core): basic spring hawk #3
Open
+185
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neSpecc
requested changes
Nov 25, 2024
There was a problem hiding this comment.
why hawk.java package is removed?
Comment on lines
+18
to
+19
| private static int errorCount = 0; | ||
| private static int warningCount = 0; |
There was a problem hiding this comment.
why these increments are needed? I'd suggest to remove all unused code
There was a problem hiding this comment.
also, please, do not forget to add docs to each class property
| */ | ||
| @PostConstruct | ||
| public void initialize() { | ||
| Thread.setDefaultUncaughtExceptionHandler((thread, exception) -> { |
| /** | ||
| * Constructor for PlaygroundApp. | ||
| * | ||
| * @param hawkCatcher HawkCatcher instance |
There was a problem hiding this comment.
from where app entry point should receive hawk instance?
| } | ||
|
|
||
| // Report current error status to check if there were issues | ||
| hawkCatcher.reportStatus(); |
There was a problem hiding this comment.
unexpected method. Let's start with simple global exception handling.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.