return type fixed

codex-team · Oct 21, 2023 · 3e8b497 · 3e8b497
1 parent d51c891
commit 3e8b497
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/src/presentation/http/router/note.ts b/src/presentation/http/router/note.ts
@@ -92,7 +92,7 @@ const NoteRouter: FastifyPluginCallback<NoteRouterOptions> = (fastify, opts, don
       notePublicId : NotePublicId;
     },
     Reply: {
-      deletedFlag : number
+      deletedFlag : boolean
     },
   }>('/:notePublicId', {
     schema: {
@@ -110,17 +110,12 @@ const NoteRouter: FastifyPluginCallback<NoteRouterOptions> = (fastify, opts, don
    * @todo Check user access right
    */
     const noteId = request.note?.id as number;
-    const affectedRows = await noteService.deleteNoteById(noteId);
+    const deletedFlag = await noteService.deleteNoteById(noteId);
 
     /**
      * Check if note does not exist
      */
-    if (affectedRows === false) {
-      return reply.send({ deletedFlag: 0});
-    }
-    else {
-      return reply.send({ deletedFlag: 17 }/**{ deletedFlag: noteId }*/);
-    };
+    return reply.send({ deletedFlag : deletedFlag});
   });
 
   /**

diff --git a/src/repository/storage/postgres/orm/sequelize/note.ts b/src/repository/storage/postgres/orm/sequelize/note.ts
@@ -201,7 +201,7 @@ export default class NoteSequelizeStorage {
     /**
      * If note not found, return null
      */
-    return affectedRows === 1;
+    return affectedRows > 0;
   }
 
   /**