type errors fixed

codex-team · Oct 21, 2023 · 58f0c4c · 58f0c4c
1 parent a5097f5
commit 58f0c4c
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 13 deletions.
diff --git a/src/domain/service/note.ts b/src/domain/service/note.ts
@@ -37,10 +37,10 @@ export default class NoteService {
 
   /**
    * Deletes note by id
+   *
    * @param id - note internal id
-   * @returns { Promise<boolean | null> }
    */
-  public async deleteNoteById(id: NoteInternalId){
+  public async deleteNoteById(id: NoteInternalId): Promise<boolean> {
     return await this.repository.deleteNoteById(id);
   }
 

diff --git a/src/repository/note.repository.ts b/src/repository/note.repository.ts
@@ -52,13 +52,12 @@ export default class NoteRepository {
   }
 
   /**
-   * Deletes note by id 
-   * 
+   * Deletes note by id
+   *
    * @param id - note id
-   * @returns { Promise<boolean | null> }
    */
-  public async deleteNoteById(id: NoteInternalId){
-    return await this.storage.deleteNoteById(id)
+  public async deleteNoteById(id: NoteInternalId): Promise<boolean> {
+    return await this.storage.deleteNoteById(id);
   }
 
   /**

diff --git a/src/repository/storage/postgres/orm/sequelize/note.ts b/src/repository/storage/postgres/orm/sequelize/note.ts
@@ -188,24 +188,23 @@ export default class NoteSequelizeStorage {
 
   /**
    * Deletes note by id
-   * 
+   *
    * @param id - internal id
-   * @returns { Promise<boolean> }
    */
-  public async deleteNoteById(id: NoteInternalId){
+  public async deleteNoteById(id: NoteInternalId): Promise<boolean> {
     const note = await this.model.destroy({
       where:{
         id,
-      }
-    })
+      },
+    });
 
     /**
      * If note not found, return null
      */
     if (!note) {
       return false;
     }
-    else{
+    else {
       return true;
     }
   }