Added a condition to determine whether the user is a member of the team #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
neSpecc
requested changes
Oct 26, 2023
| /** | ||
| * Checking if user is part of the team | ||
| */ | ||
| if (userId !== teamMemberId) { |
There was a problem hiding this comment.
non-creator user will never pass there, because previous if will reject him
| @@ -30,4 +30,13 @@ export default async function userInTeam(request: FastifyRequest, reply: Fastify | |||
| if (creatorId !== userId) { | |||
| return await reply.forbidden(); | |||
| } | |||
|
|
|||
| const { teamMemberId } = request; | |||
There was a problem hiding this comment.
you need to add this property to request (if it is required for most requests), or access domain service from there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.