-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for get note by id #99
Conversation
New data for tests were added to the test database
url for a fake request define using the find method
fix implicit arrange
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need one more case:
- Should return a Note when public access is disabled but user is creator
Need to decide what to do with the note creator.
I suggest adding such a testcase in a todo manner, because the ability to perform requests with authorization is not implemented yet and it seems like separate task |
so lets add all left test cases with this manner |
I understand correctly that there should be the following @todo?
|
test for incorrect id should be implemented, since this logic already exists. The second one should be added with todo mark |
Removed 1 test case for 406
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect
Testcases were written for the get note by id method
New data for tests were added to the test database