Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update to Next.js 14 #51

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

feat: Update to Next.js 14 #51

wants to merge 2 commits into from

Conversation

codinsonn
Copy link
Owner

@codinsonn codinsonn commented Oct 26, 2023 •
edited
Loading

This PR:

  • Bumps Next.js version to 14
  • Removes Expo Vector Icons as it's no longer recommended due to tree shaking issues
  • Temporarily turns off generateStaticParams() to get build to work
  • Solves an issue with children not being passed during Hydration
  • Implements the recommend migration path from generateStaticParams() with 'use client'
  • Fixes Next.js 14 build command (errors on _Head being undefined for 404 & 500)

Issue with children prop dissapearing during hydration

https://nextjs-forum.com/post/1167209851001249812

Screen.Recording.2023-10-26.at.23.29.17.mov

Issue with _Head being undefined for 404 & 500 pages during build

Screenshot 2023-10-27 at 00 00 56

@codinsonn codinsonn self-assigned this Oct 26, 2023
@vercel
Copy link

vercel bot commented Oct 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codinsonndotdev ❌ Failed (Inspect) Oct 26, 2023 9:56pm

@codinsonn codinsonn force-pushed the feat/next-14-upgrade branch from e955900 to c0dd023 Compare October 26, 2023 21:52
@codinsonn codinsonn marked this pull request as draft November 2, 2023 05:33
@codinsonn codinsonn force-pushed the main branch 8 times, most recently from b4cdc94 to 68457a5 Compare January 11, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@codinsonn codinsonn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@codinsonn