Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

Add pagination ability #192

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Add pagination ability #192

merged 4 commits into from
Mar 20, 2024

Conversation

gmrabian
Copy link
Collaborator

@gmrabian gmrabian commented Mar 20, 2024

Summary

Built pagination option per accessibility guidance and to speed up initial app load.
Loads 20 colleges and has a "Load more" button to get 20 at a time.
Filtering works with entire dataset. When you remove filtering it goes back to pagination.

  • Updated details and confirmation pages to pull college from context object
  • Update tests

Fixes #195

Type of change

  • New feature (non-breaking change which adds functionality)

How To Test

  • Browse page loads faster
  • "Load more" loads 20 more colleges at a time
  • Filtering works with full college dataset
  • Removing filters goes back to paginated set

Checklist:

  • My code follows the style guidelines of this project and has no linting errors
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation, including any applicable ADRs
  • My changes generate no new warnings
  • I have added tests that fail without these changes
  • New and existing tests (unit, integration, accessibility) pass locally
  • Documentation updated
  • If there are security concerns they are addressed or ticketed after being discussed

@gmrabian gmrabian self-assigned this Mar 20, 2024
@gmrabian gmrabian added frontend For work that is primarily in the front end of the application HCD For work related to human centered design and documentation ready for review Ready for review accessibility labels Mar 20, 2024
@gmrabian gmrabian marked this pull request as ready for review March 20, 2024 15:36
@gmrabian gmrabian changed the title Add pagination ability; needs rework with filters Add pagination ability Mar 20, 2024
Copy link

codeclimate bot commented Mar 20, 2024

Code Climate has analyzed commit b3ea0fd and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 76.2% (80% is the threshold).

This pull request will bring the total coverage in the repository to 86.7%.

View more on Code Climate.

@gmrabian gmrabian merged commit 9160e51 into main Mar 20, 2024
27 of 29 checks passed
@gmrabian gmrabian deleted the pagination-demo branch March 20, 2024 15:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accessibility frontend For work that is primarily in the front end of the application HCD For work related to human centered design and documentation ready for review Ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pagination on user page
2 participants