Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

Add functionality for filter chips #208

Merged
merged 6 commits into from
Mar 20, 2024
Merged

Add functionality for filter chips #208

merged 6 commits into from
Mar 20, 2024

Conversation

braxex
Copy link
Collaborator

@braxex braxex commented Mar 20, 2024

Summary

We need filter chips to enhance the user experience of filtering, and also to surface warnings for users if their filters are not returning results because they are categorically excluding all institutions with a single filter. This PR adds filter chips to notify the user of filtering functionality, and warning and guidance text for users.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How To Test

Pull down code, test through filters, deselect all checkboxes within a filter type, validate that warnings show. Validate that filter chips show.

Checklist:

  • My code follows the style guidelines of this project and has no linting errors
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation, including any applicable ADRs
  • My changes generate no new warnings
  • [ ] I have added tests that fail without these changes
  • New and existing tests (unit, integration, accessibility) pass locally
  • [ ] Documentation updated
  • [ ] If there are security concerns they are addressed or ticketed after being discussed

Copy link

codeclimate bot commented Mar 20, 2024

Code Climate has analyzed commit e9bca7a and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

The test coverage on the diff in this pull request is 95.3% (80% is the threshold).

This pull request will bring the total coverage in the repository to 95.5% (0.0% change).

View more on Code Climate.

@braxex braxex merged commit 68787d1 into main Mar 20, 2024
12 checks passed
@braxex braxex deleted the filter-chips branch March 20, 2024 18:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants