Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload dask-searchCV notebook #101

Merged
merged 1 commit into from
Jun 12, 2017
Merged

Conversation

rdvelazquez
Copy link
Member

This PR continues on PR #98.

The notebook shows the implementation of dask-searchcv to speed up the pipeline and allow for implementing PCA in cross-validation. This PR is the first step in addressing Issue #94 ... The next step will be to implement dask-searchcv in the main notebooks after #93 is merged.

@dhimmel
Copy link
Member

dhimmel commented Jun 9, 2017

What version of dask-searchcv did you use? We will need to add this to our environment.

@rdvelazquez
Copy link
Member Author

I followed the instructions from the dask/dask-searchcv github page:

# Install with conda
$ conda install dask-searchcv -c conda-forge

When I list my packages installed in anaconda it shows :

dask 0.14.3
dask-searchcv 0.0.2

@rdvelazquez
Copy link
Member Author

We will need to add this to our environment.

Should I open a new pull-request to add dask-searchcv to environment.yml and to the main notebooks or should that be part of this PR? Also, I don't know if the notebook currently in this PR is really a necessary addition (it was more just my own evaluation of dask-searchcv) so I'm fine with leaving this notebook out and just focusing on implementing dask-searchCV in the main notebooks. Just let me know.

@dhimmel
Copy link
Member

dhimmel commented Jun 12, 2017

Also, I don't know if the notebook currently in this PR is really a necessary addition

I think it's appropriate in explore. I'll merge this now. You can do another PR to implement dask-searchcv in the main notebooks and add it to the environment. I'd suggest waiting until we merge #100 and then starting your PR from there.

@dhimmel dhimmel merged commit 2379eb2 into cognoma:master Jun 12, 2017
@rdvelazquez rdvelazquez deleted the daskSearchCV branch June 17, 2017 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants