Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add checkbox atomic component #11

Merged
merged 3 commits into from
Oct 21, 2024
Merged

feat!: add checkbox atomic component #11

merged 3 commits into from
Oct 21, 2024

Conversation

ishaan000
Copy link
Collaborator

feat!: add checkbox atomic component

  • Added Checkbox.tsx and Checkbox.types.d.ts.
    • Wrapped MuiCheckbox and FormControlLabel in new Checkbox component.
  • Added test suite for checkbox, Checkbox.test.tsx.

- Added Checkbox.tsx and Checkbox.types.d.ts.
  - Wrapped MuiCheckbox and FormControlLabel in new Checkbox component.
- Added test suite for checkbox, Checkbox.test.tsx.
@ishaan000 ishaan000 added enhancement New feature or request components Related to React components feature Related to new feature labels Sep 24, 2024
@ishaan000 ishaan000 self-assigned this Sep 24, 2024
@hiyaryan hiyaryan marked this pull request as draft October 8, 2024 23:17
@ishaan000 ishaan000 marked this pull request as ready for review October 9, 2024 00:40
Copy link
Member

@hiyaryan hiyaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Great work @ishaan000!

  • Can use component
  • Tests pass
  • No lint errors

@hiyaryan hiyaryan merged commit 51f535f into main Oct 21, 2024
1 check passed
@hiyaryan hiyaryan deleted the atom-checkbox branch October 21, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
components Related to React components enhancement New feature or request feature Related to new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants