Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add link atomic component #14

Merged
merged 1 commit into from
Oct 21, 2024
Merged

feat!: add link atomic component #14

merged 1 commit into from
Oct 21, 2024

Conversation

ishaan000
Copy link
Collaborator

  • Added Link.tsx and Link.types.d.ts.
    • Wrapped MuiLink in new Link component.
    • Added error handling to make sure href is provided, throws a runtime error if not.
  • Added test suite for link, Link.test.tsx.

- Added Link.tsx and Link.types.d.ts.
  - Wrapped MuiLink in new Link component.
- Added test suite for link, Link.test.tsx.
@ishaan000 ishaan000 added enhancement New feature or request components Related to React components dev Related to development environment labels Oct 11, 2024
@ishaan000 ishaan000 requested a review from hiyaryan October 11, 2024 16:30
@ishaan000 ishaan000 self-assigned this Oct 11, 2024
@hiyaryan hiyaryan added feature Related to new feature and removed dev Related to development environment labels Oct 21, 2024
Copy link
Member

@hiyaryan hiyaryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Link looks good! Great work @ishaan000!

  • Can use component
  • Tests pass
  • No lint errors

@hiyaryan hiyaryan merged commit 195bc97 into main Oct 21, 2024
1 check passed
@hiyaryan hiyaryan deleted the atom-link branch October 21, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
components Related to React components enhancement New feature or request feature Related to new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants