Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove .js and .jsx extensions from lint script #16

Closed
wants to merge 1 commit into from

Conversation

hiyaryan
Copy link
Member

@hiyaryan hiyaryan commented Nov 1, 2024

Linter is not configured to lint .js and .jsx files and hangs when script it ran. ESLint should be configured to lint .js and .jsx files if they become used for more than config files.

Linter is not configured to lint .js and .jsx files and hangs when script it ran. ESLint should be configured to lint .js and .jsx files if they become used for more than config files.
@hiyaryan hiyaryan added bug Something isn't working ci Related to continuous integration styles Related to code formatting, styles, and linting. labels Nov 1, 2024
@hiyaryan hiyaryan self-assigned this Nov 1, 2024
@hiyaryan hiyaryan closed this Nov 1, 2024
@hiyaryan
Copy link
Member Author

hiyaryan commented Nov 1, 2024

@ishaan000 I figured out why the linter wasn't running so we don't need this "fix" anymore. It was due to the /docs directory that I've been working on locally. This verifies that warnings are not shown in the CI like you were saying.

@hiyaryan
Copy link
Member Author

hiyaryan commented Nov 1, 2024

This verifies that warnings are not shown in the CI like you were saying.

Actually it doesn't, because the file that has the error is ignored. next-env.d.ts is an environment file that is ignored like .env. next-env.d.ts might contain sensitive information so it shouldn't be pushed to the repo. Nonetheless, this PR is no longer needed.

@hiyaryan hiyaryan deleted the eslint-update branch November 1, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Related to continuous integration styles Related to code formatting, styles, and linting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant