perf: wrap link component in NextLink #17
Conversation
ishaan000
added
components
There was a problem hiding this comment.
@ishaan000 Looks good! The only thing I'd update is the commit message. So this would be perf instead of feat!, for a performance improvement rather than a breaking change. We also want to be a little more specific in the commit message, so I'd write perf: wrap link component in NextLink with the body of the commit explaining the changes and how it improves the component. Then for the PR itself, it helps to elaborate more in the first comment block in the conversation. Having a good PR write up is really useful. So a PR write up you should provide links to resources you used, images, and thoroughly explain what this PR does. Use your commit body as an outline for your PR write up instead of using it as the write up itself. Here's an example of a good PR write up cognovi-ai/the-cdj#91
ishaan000
changed the title
Wrap the Link component with Next.js Link for performance and native support. Remove logic allowing Link to act as a button without href, enforcing href as required. Update tests to reflect these changes, removing button-specific checks.
ishaan000
force-pushed
the
link-update-1
branch
from
0bf77f5
to
b35a079
Compare
Why This Improves Performance:
Client-Side Navigation: Using Next.js’ Link component enables client-side transitions, which keep route changes within the app without triggering a full-page reload. This results in faster navigation and smoother user experience. (See Next.js Link documentation)
Prefetching for Faster Loading: Next.js prefetches pages linked with its Link component, loading content in the background while users browse. This allows for near-instant transitions to linked pages, improving perceived performance. (See Next.js Performance Optimization Guide)
Enforced Consistency and Simplified Logic: By requiring href on all Link components, this update removes ambiguity in component behavior, aligns with Next.js best practices, and simplifies navigation logic by focusing on links as navigation elements.