feat!: add button atomic component #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ishaan000
added
enhancement
- Added Button.tsx and Button.types.d.ts. - Wrapped MuiButton in new Button component. - Added test suite for button, Button.test.tsx.
ishaan000
force-pushed
the
4-atom-button
branch
from
c6e70ad to
8fa7f63
Compare
ishaan000
changed the title
- Added aria-label and tabIndex to Button.tsx and Button.types.d.ts. - Added accessibility tests in button test suite.
- Adds sx prop to make Button customizable. - Added test in Button to ensure sx prop is contained in Button.
hiyaryan
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is for the Button atomic component :