Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: containerize the-cdj-ui dev env #7

Merged
merged 1 commit into from
Sep 21, 2024
Merged

build: containerize the-cdj-ui dev env #7

merged 1 commit into from
Sep 21, 2024

Conversation

hiyaryan
Copy link
Member

  • Added Dockerfile to containerize the-cdj-ui development environment.
  • Created compose.yml for environment setup.
  • Included .dockerignore to optimize Docker build context.
  • Updated package.json node version for consistency with the container specifying Node.js engine version >=20.

@hiyaryan
build: containerize the-cdj-ui dev env
69e7344 
- Added Dockerfile to containerize the-cdj-ui development environment.
- Created compose.yml for environment setup.
- Included .dockerignore to optimize Docker build context.
- Updated package.json node version for consistency with the container specifying Node.js engine version >=20.
@hiyaryan hiyaryan added enhancement New feature or request patch Related to a patch release build Related tp building the project env Related to the runtime environment. labels Sep 20, 2024
@hiyaryan hiyaryan self-assigned this Sep 20, 2024
@hiyaryan hiyaryan added dev Related to development environment env Related to the runtime environment. and removed patch Related to a patch release env Related to the runtime environment. labels Sep 20, 2024
davidzlu
davidzlu approved these changes Sep 21, 2024
View reviewed changes
Copy link
Collaborator

@davidzlu davidzlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Great work!

@hiyaryan hiyaryan merged commit 18701f0 into main Sep 21, 2024
2 checks passed
@hiyaryan hiyaryan deleted the containerize-the-cdj-ui branch September 21, 2024 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidzlu davidzlu davidzlu approved these changes

Assignees

@hiyaryan hiyaryan

Labels
build Related tp building the project dev Related to development environment enhancement New feature or request env Related to the runtime environment.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiyaryan @davidzlu