Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wip/v2 #11

Open
wants to merge 22 commits into
base: master
Choose a base branch
from
Open

Wip/v2 #11

wants to merge 22 commits into from

Conversation

agb94
Copy link
Collaborator

@agb94 agb94 commented Jun 23, 2020

No description provided.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.0%) to 73.434% when pulling 4ef40a4 on bloa:wip/v2 into 6cb31a3 on coinse:master.

target_files = self.contents.keys()
modification_points = copy.deepcopy(self.modification_points)
new_contents = copy.deepcopy(self.contents)
for target_file in target_files:
edits = list(filter(lambda a: a.target[0] == target_file, patch.edit_list))
for edit in edits:
edit.apply(self, new_contents, modification_points)
if minify and len(edits) == 0:
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if minify and not edits

would to more pythonic 😺 (reference)

@bloa
Copy link
Collaborator

bloa commented Jul 1, 2020

Hi Gabin,

You should ping me or assign me as reviewer otherwise I am not notified when you open a pull request or ask questions.
The branchs wip/* should probably not be used directly. As you noticed, sometimes changes are not made in a single commit, I change my mind, and commit messages are not exactly always perfect ("??!", sic...)
Furthermore, there are changes that should be merged quickly, others that should not raise any problem, and others that are not ready and should be discussed first.

I created others branches more suitable for pull requests:

  • fix/misc contains the commits that fix something currently broken
  • feat/misc contains the commits that brings something new, but very minor, and should be safe to merge
  • feat/cleanup, wip/reset, wip/minify, and feat/select are (will be) for the features that should be discussed first and might need some fine tuning (I can open issues for those)

Let me know if you want me to change or rebase anything; as long as its on my fork nobody should mind if I force-push my own branches.
Finally, the network graph might help you with all these new branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants