Enable selective test execution in Mill's own CI #4118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
lihaoyi
added a commit
that referenced
this pull request
Dec 12, 2024
Some cleanup in preparation for #4118 Set default `--jobs=0.5C` in `.mill-opts` so we don't need to specify it explicitly in CI, and it also works on laptops and other environments with different core counts correctly. TBH could probably go with even less parallelism due to how heavy our integration tests are - with all the compilation and JVM subprocess spawning they can probably easily take up all 4 cores on a Github Actions worker - but I'm leaving it at 0.5C X 4 cores = 2x parallelism in CI for now Also simplified the windows CI setup: now that we have `./mill.bat` in the project root, we can just call `./mill` in the windows terminal. I had to delete the `.ps1` version because it was taking priority over `.bat` and failing with the following error: ``` Run ./mill -i -k __.compile mill.ps1: D:\a\_temp\93d23[8](https://github.com/com-lihaoyi/mill/actions/runs/12292451871/job/34303135448#step:11:8)[8](https://github.com/com-lihaoyi/mill/actions/runs/12292451871/job/34303135448#step:11:9)4-066d-433e-bb26-8539b01a4aee.ps1:2 Line | 2 | ./mill -i -k __.compile | ~~ | Parameter cannot be processed because the parameter name 'i' is ambiguous. Possible matches include: | -InformationAction -InformationVariable. Error: Process completed with exit code 1. ```
lihaoyi
added a commit
that referenced
this pull request
Dec 13, 2024
Needs to happen separately from #4118 since I need it on both the PR branch and on the main target branch for the selective testing to be effective
|
Selective execution seems to work in Mill's CI now for pre-merge PR validation, will merge it and work on post-merge master validation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.