Speed up task resolution and planning logic #4132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4129 and #4026. We never really looked at performance at this stuff before, but in order to support
selective.prepare __
(the default ofselective.prepare
) we need to improve these bottlenecksIntroduces the
ResolveCore#Cache
class that holds mutable dictionaries to memo-ize various expensive parts of the task resolution logicLots of micro-optimizations in various places: cache
Segments#hashCode
, avoid callingSegments#render
for sorting orSegments#part
for taking the last part, etc.Brings down
time ./mill plan __
from ~60s to ~3s