-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: lint code #114
chore: lint code #114
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
- Coverage 77.15% 76.91% -0.24%
==========================================
Files 23 23
Lines 2057 2058 +1
==========================================
- Hits 1587 1583 -4
- Misses 399 403 +4
- Partials 71 72 +1
|
let's do it. codecov is unhelpful anyhow. |
Co-authored-by: Jasmina Malicevic <[email protected]>
Co-authored-by: Jasmina Malicevic <[email protected]>
Co-authored-by: Jasmina Malicevic <[email protected]>
Co-authored-by: Jasmina Malicevic <[email protected]>
Co-authored-by: Jasmina Malicevic <[email protected]>
Co-authored-by: Jasmina Malicevic <[email protected]>
…ble-cause-should-do-both
…-pebble-cause-should-do-both
Is it possible to exclude Pebble from this PR and make it only about lint changes? |
#112 needs to be merged first. |
Co-authored-by: Anton Kaliaev <[email protected]>
@melekes yes, I agree. |
…ble-cause-should-do-both
…://github.com/faddat/cometbft-db into faddat/lint-after-pebble-cause-should-do-both
linters-settings: | ||
errcheck: | ||
check-blank: true | ||
depguard: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mind bringing this back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few minutes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally, depguard isn't in my lint religion -- did you want it back & configured?
looks like I broke something. sorry about that |
Oh that's okay I'll fix it |
I'll add a make test-pebble to default test runs.. |
CHANGELOG.md
Outdated
@@ -1,5 +1,9 @@ | |||
# CHANGELOG | |||
|
|||
*Jan 24, 2024* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove
Closes: #113
This PR lints tm-db
closes: #113