Skip to content
This repository has been archived by the owner on Mar 23, 2021. It is now read-only.

Noise Handshake Future #732

Merged
merged 17 commits into from
Feb 5, 2019
Merged

Noise Handshake Future #732

merged 17 commits into from
Feb 5, 2019

Conversation

D4nte
Copy link
Contributor

@D4nte D4nte commented Jan 31, 2019

Resolves #668

@ghost ghost assigned D4nte Jan 31, 2019
@ghost ghost added the review label Jan 31, 2019
@D4nte D4nte force-pushed the 668-noise-handshake-protocol branch 2 times, most recently from d4a197d to d352865 Compare January 31, 2019 00:42
thomaseizinger
thomaseizinger suggested changes Jan 31, 2019
View reviewed changes
vendor/noise_handshake/src/handshake.rs Outdated Show resolved Hide resolved
vendor/noise_handshake/src/handshake.rs Outdated Show resolved Hide resolved
vendor/noise_handshake/src/handshake.rs Outdated Show resolved Hide resolved
vendor/noise_handshake/src/lib.rs Outdated Show resolved Hide resolved
vendor/noise_handshake/src/handshake.rs Show resolved Hide resolved
@D4nte D4nte force-pushed the 668-noise-handshake-protocol branch 2 times, most recently from 6f9120c to d95ad9d Compare January 31, 2019 10:59
@D4nte D4nte requested a review from a team January 31, 2019 11:41
luckysori
luckysori reviewed Feb 1, 2019
View reviewed changes
Copy link
Contributor

@luckysori luckysori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor comments, but it looks really clear! Good job 😀

vendor/noise_handshake/src/handshake.rs Outdated Show resolved Hide resolved
vendor/noise_handshake/src/handshake.rs Outdated Show resolved Hide resolved
@D4nte
Copy link
Contributor Author

D4nte commented Feb 1, 2019

@luckysori says it looks clear so I am happy 😄

LLFourn
LLFourn suggested changes Feb 1, 2019
View reviewed changes
Copy link
Collaborator

@LLFourn LLFourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. There was one thing I wasn't sure of so I put a ❌ on it.

vendor/noise_handshake/src/handshake.rs Outdated Show resolved Hide resolved
vendor/noise_handshake/src/handshake.rs Outdated Show resolved Hide resolved
vendor/noise_handshake/src/handshake.rs Outdated Show resolved Hide resolved
vendor/noise_handshake/src/handshake.rs Outdated Show resolved Hide resolved
@LLFourn LLFourn mentioned this pull request Feb 1, 2019
Closed
@D4nte
Copy link
Contributor Author

D4nte commented Feb 1, 2019

Not yet ready, still need to stabilise Travis

@D4nte
Copy link
Contributor Author

D4nte commented Feb 1, 2019

Build successful. @LLFourn @thomaseizinger please approve.

LLFourn
LLFourn approved these changes Feb 3, 2019
View reviewed changes
Copy link
Collaborator

@LLFourn LLFourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but I noticed some superficial things that should change before merging.

@D4nte D4nte force-pushed the 668-noise-handshake-protocol branch from 5ef644c to c197163 Compare February 5, 2019 04:19
@mergify mergify bot merged commit b26d30f into master Feb 5, 2019
@mergify mergify bot deleted the 668-noise-handshake-protocol branch February 5, 2019 04:36
@ghost ghost removed the review label Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@luckysori luckysori luckysori left review comments

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@LLFourn LLFourn LLFourn approved these changes

Assignees

@D4nte D4nte

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@D4nte @LLFourn @thomaseizinger @luckysori