Update README.md #171
Open
Update README.md #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerryster
requested changes
Nov 11, 2020
There was a problem hiding this comment.
@AmanSharma123456 , thanks for your interest in this project. I see a couple of themes to your PR:
- You like the definite article (the word "the").
- You like the Oxford Comma. I am also a fan of the Oxford Comma as it leads to clarity in some cases. https://www.verbicidemagazine.com/2011/09/20/strippers-jfk-and-stalin-illustrate-why-you-should-use-the-serial-comma/ is a good example of this.
- Capitalization of proper nouns.
- Using a comma to separate introductory phrases such as when a sentence begins with the word such as "additionally."
- Preposition updates.
I am a native American English speaker, and in general I agree with your changes. I did add a note regarding two places which we do not want to change as they refer to actual JavaScript methods.
|
|
||
| ### Name | ||
|
|
||
| The `name` names the holiday in the local language of the selected country, | ||
| state, region. The applied language(s) can be requested using `getLanguages()`. | ||
|
|
||
| The language can be changed using the `setLanguages()` method. In case that not | ||
| The language can be changed using the `set languages()` method. In case that not |
There was a problem hiding this comment.
This should not be changed as it is referring to an actual method and not an English string.
| translation is available a fall-back to the next given language will be made. | ||
| E.g. local language is "fr", `setLanguages('nl')` was called. For all holidays | ||
| where no dutch translation is available the French version will be used instead. | ||
| E.g. local language is "fr", `set languages('nl')` was called. For all holidays |
There was a problem hiding this comment.
Same here...this should refer to the actual JavaScript method.
|
@AmanSharma123456 : any interest in pursuing these changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Grammatical Errors removed.