added cloudtrailEnable option to fix #173 #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmonkman
reviewed
Oct 25, 2021
| @@ -83,6 +83,7 @@ data "aws_iam_policy_document" "operator_access" { | |||
| resources = ["arn:aws:s3:::*${local.domain_name}/*"] | |||
| } | |||
|
|
|||
| <% if eq(index .Params `cloudtrailEnable`) "yes" %> | |||
There was a problem hiding this comment.
Needs a space between eq and (, this is causing the validation to fail. Need to improve the error output there for sure..
There was a problem hiding this comment.
Created commitdev/zero#431 to improve error handling
bmonkman
reviewed
Oct 25, 2021
| @@ -93,7 +94,7 @@ data "aws_iam_policy_document" "operator_access" { | |||
| effect = "Allow" | |||
| actions = ["s3:GetObject", "s3:PutObject"] | |||
| resources = ["arn:aws:s3:::${data.terraform_remote_state.shared.outputs.cloudtrail_bucket_id}/*"] | |||
There was a problem hiding this comment.
It's more permissive but how about instead of making this whole block conditional we just wildcard it to allow access to all cloudtrail buckets. "arn:was:s3:::*-cloudtrail/*" (invalidates the comment above)
deven96
force-pushed
the
cloudtrail-savings
branch
from
fa31402
to
4e49075
Compare
bmonkman
approved these changes
Oct 28, 2021
pmoranga
added a commit
to pmoranga/zero-aws-eks-stack
that referenced
this pull request
Jan 20, 2022
pmoranga
added a commit
to pmoranga/zero-aws-eks-stack
that referenced
this pull request
Jan 21, 2022
bmonkman
pushed a commit
that referenced
this pull request
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.