-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Secrets #26
Draft
tetron
wants to merge
5
commits into
main
Choose a base branch
from
secrets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Secrets #26
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a321dbb
PR to add "secret" field to input parameters.
tetron 36ab5e2
Add text about checking correctness for secrets.
tetron 02abe0c
Fix typos
tetron a579af7
New design (3rd one today) with explicit SecretText object type.
tetron 9be8fad
Update changelog
tetron File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -385,7 +385,69 @@ $graph: | |||||||||
from the input object, or if the value of the parameter in the input | ||||||||||
object is `null`. Default values are applied before evaluating expressions | ||||||||||
(e.g. dependent `valueFrom` fields). | ||||||||||
|
||||||||||
- name: secret | ||||||||||
type: ["null", boolean, string] | ||||||||||
doc: | | ||||||||||
Indicates this input parameter value is sensitive. | ||||||||||
Implementations should apply special handling to secret values | ||||||||||
to avoid displaying them in logs, including them in output, or | ||||||||||
otherwise making them visible or accessible in any way beyond | ||||||||||
what is required to make the value of the secret input | ||||||||||
parameter available to workflow processes that need it. | ||||||||||
|
||||||||||
This feature is intended to provide a safer way to handle | ||||||||||
credentials such as passwords and API tokens. | ||||||||||
|
||||||||||
Possible values of the `secret` field can be: | ||||||||||
|
||||||||||
* null or not provided (default, the input parameter is not secret) | ||||||||||
* false (same as null) | ||||||||||
* true (parameter is secret) | ||||||||||
* a non-empty string (parameter is secret, and may be looked up in platform storage) | ||||||||||
|
||||||||||
If the value of `secret` is a string, this is a lookup key to | ||||||||||
be used to fetch a secret value from the workflow platform | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
secret store. This assumes a model where a non-sensitive | ||||||||||
lookup key is passed to the secret store and a sensitive | ||||||||||
string value (the password, API token, etc) is returned. | ||||||||||
|
||||||||||
The format of this lookup key, as well as management, access | ||||||||||
permissions, and authentication for the secret store are | ||||||||||
implementation specific and out of scope for this document. | ||||||||||
|
||||||||||
If the input parameter is a secret, the `type` of the input | ||||||||||
parameter must only consist of `string`, `array<string>`, or | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||
`null`. | ||||||||||
|
||||||||||
If `secret` is a string and the platform supports looking up | ||||||||||
credentials, the input parameter is implicitly optional for | ||||||||||
the caller, and platform should look up the secret to fill in | ||||||||||
the input parameter value when not provided by the caller. | ||||||||||
|
||||||||||
An explicit value provided by the caller always takes | ||||||||||
precedence over looking up a value, i.e. checking the secret | ||||||||||
store must only happen if the caller did not provide an | ||||||||||
explicit value for this secret parameter, or the value is | ||||||||||
null. | ||||||||||
|
||||||||||
If the platform does not support secrets lookup, a string | ||||||||||
value of `secret` is treated like boolean true, indicating the | ||||||||||
parameter is secret, but must be provided in the input | ||||||||||
document (unless marked as optional). | ||||||||||
|
||||||||||
Failure to look up the secret (for example, due to denial of | ||||||||||
access) may yield a value of "null". Execution continues only | ||||||||||
if the parameter is optional (i.e. "null" is an accepted | ||||||||||
type). However implementations may, at user option, treat | ||||||||||
failure to look up a secret as a fatal error. | ||||||||||
|
||||||||||
Workflow engines should verify that, when a secret is passed | ||||||||||
through multiple levels (e.g. from a parent workflow to a | ||||||||||
sub-workflow to a command line tool), it is secret at every | ||||||||||
level, for example through a check that secret inputs are only | ||||||||||
be passed to workflow steps where the inputs are also marked | ||||||||||
as secret, or that secret inputs to a workflow step are | ||||||||||
themselves secret at the parent workflow level. | ||||||||||
|
||||||||||
- name: OutputParameter | ||||||||||
type: record | ||||||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.