Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose read-write accessors. #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

tmpfs
Copy link
Contributor

@tmpfs tmpfs commented Mar 29, 2016

For lastLineBlank, htmlBlockType and a data property which allows AST
consumers to associate arbitrary data with an AST node.

For lastLineBlank, htmlBlockType and a `data` property which allows AST
consumers to associate arbitrary data with an AST node.
@jgm
Copy link
Member

jgm commented Aug 1, 2017

I understand about data, but the others are internal state for the parser; why would users need to alter them?

@tmpfs
Copy link
Contributor Author

tmpfs commented Aug 2, 2017

I need to know the type of html block type under quite a few scenarios, IIRC particularly to determine if a block is a processing instruction or not. It just feels wrong to be accessing the private variables. I forget for lastLineBlank but i think it was to do with lists at the end of partials and determining whether i need to add and additional line or not. It has been a long time so i would have to read the code again...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants