Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(io): revise vectored methods #355

Merged
merged 2 commits into from
Dec 19, 2024
Merged

refactor(io): revise vectored methods #355

merged 2 commits into from
Dec 19, 2024

Conversation

Berrysoft
Copy link
Member

This is a refactor of vectored methods.

  • Don't loop in fallback methods.
  • More vectored methods for slices and vectors.

@Berrysoft Berrysoft added the package: io Related to compio-io label Nov 29, 2024
@Berrysoft Berrysoft self-assigned this Nov 29, 2024
@Berrysoft
Copy link
Member Author

Berrysoft commented Dec 2, 2024 •
edited
Loading

I would like to ask for some advice to this PR:)

@Berrysoft Berrysoft added this to the v0.14 milestone Dec 2, 2024
George-Miao
George-Miao approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@George-Miao George-Miao merged commit 6f7e828 into compio-rs:master Dec 19, 2024
51 checks passed
@Berrysoft Berrysoft deleted the refactor/io-vectored branch December 20, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@George-Miao George-Miao George-Miao approved these changes

@Xuanwo Xuanwo Awaiting requested review from Xuanwo

@AsakuraMizu AsakuraMizu Awaiting requested review from AsakuraMizu

Assignees

@Berrysoft Berrysoft

Labels
package: io Related to compio-io
Projects
None yet
Milestone
v0.14
Development

Successfully merging this pull request may close these issues.
2 participants
@Berrysoft @George-Miao