Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): fix runtime drop borrowing #360

Merged
merged 2 commits into from
Dec 1, 2024

Conversation

Berrysoft
Copy link
Member

Closes #359

@Berrysoft Berrysoft added bug Something isn't working package: runtime Related to compio-runtime labels Dec 1, 2024
@Berrysoft Berrysoft self-assigned this Dec 1, 2024
Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@George-Miao
Copy link
Member

Can you add the minimum reproducible code in the issue to an exmaple/test?

@Berrysoft
Copy link
Member Author

Can you add the minimum reproducible code in the issue to an exmaple/test?

No, I'm not able to construct an MWE:(

Copy link
Collaborator

@AsakuraMizu AsakuraMizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that the code in #359 now does not cause BorrowMutError.

@Berrysoft Berrysoft merged commit f1bbb55 into compio-rs:master Dec 1, 2024
51 checks passed
@Berrysoft Berrysoft deleted the fix/runtime-drop branch December 1, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package: runtime Related to compio-runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BorrowMutError in compio-runtime 0.6.2
3 participants