Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(driver): remove one Result usage #369

Merged
merged 2 commits into from
Dec 19, 2024
Merged

refactor(driver): remove one Result usage #369

merged 2 commits into from
Dec 19, 2024

Conversation

Berrysoft
Copy link
Member

I'm not sure whether we will change the implementation in the future, but it doesn't need to return Result now.

@Berrysoft Berrysoft self-assigned this Dec 15, 2024
@Berrysoft Berrysoft added package: driver Related to compio-driver refactor Refactoring existing code labels Dec 15, 2024
@Berrysoft Berrysoft added this to the v0.14 milestone Dec 15, 2024
AsakuraMizu
AsakuraMizu reviewed Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@AsakuraMizu AsakuraMizu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So... if I'm right, this io::Result was originally introduced by #149 because of a try_clone and later fixed by #306?

@Berrysoft
Copy link
Member Author

So... if I'm right, this io::Result was originally introduced by #149 because of a try_clone and later fixed by #306?

Yes. The return type wasn't changed to keep API stable.

George-Miao
George-Miao approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@George-Miao George-Miao merged commit 415c8db into compio-rs:master Dec 19, 2024
51 checks passed
@Berrysoft Berrysoft deleted the refactor/new-notify-handle branch December 20, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@George-Miao George-Miao George-Miao approved these changes

@AsakuraMizu AsakuraMizu AsakuraMizu approved these changes

Assignees

@Berrysoft Berrysoft

Labels
package: driver Related to compio-driver refactor Refactoring existing code
Projects
None yet
Milestone
v0.14
Development

Successfully merging this pull request may close these issues.
3 participants
@Berrysoft @AsakuraMizu @George-Miao