Skip to content

Commit

Permalink
only install binary distributions
Browse files Browse the repository at this point in the history
I'm not sure why during the resolve, pip tries sckit-learn 1.1.2, and
that requires a build, which fails. The same thing happens using `pip
install --ignore-installed --dry-run .`. But generally, it probably
makes sense to avoid compiling from source in a github action.
  • Loading branch information
paretje committed Jul 8, 2024
1 parent 1f0915c commit 7744391
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:

- name: Build and install ms2rescore package
run: |
pip install .[dev]
pip install --only-binary :all: .[dev]
- name: Test with pytest
run: |
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ dependencies = [
# "numpy==1.24.3; python_version == '3.11'", # Incompatibility with sklearn, pygam, and TF...
# "numpy>=1.16.0; python_version != '3.11'",
"numpy>=1.16.0",
"scikit-learn==1.5.1; python_version == '3.11'",
"pandas>=1.0",
"plotly>=5",
"psm_utils>=0.9",
Expand Down

0 comments on commit 7744391

Please sign in to comment.