Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add I/O support for some DIA search engines #103

Merged
merged 14 commits into from
Nov 6, 2024
Merged

Add I/O support for some DIA search engines #103

merged 14 commits into from
Nov 6, 2024

Conversation

rodvrees
Copy link
Member

@rodvrees rodvrees commented Oct 31, 2024

Added

  • io.alphadia: Read support for AlphaDIA precursors.tsv
  • io.fragpipe: Read support for FragPipe psm.tsv
  • io.diann: Read support for DIA-NN TSV

@rodvrees rodvrees requested a review from RalfG October 31, 2024 14:50
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

Attention: Patch coverage is 93.24324% with 10 lines in your changes missing coverage. Please review.

Project coverage is 69.03%. Comparing base (27b8591) to head (029ba11).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
psm_utils/io/fragpipe.py 93.22% 4 Missing ⚠️
psm_utils/io/alphadia.py 93.47% 3 Missing ⚠️
psm_utils/io/diann.py 92.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   67.67%   69.03%   +1.36%     
==========================================
  Files          27       30       +3     
  Lines        2633     2781     +148     
==========================================
+ Hits         1782     1920     +138     
- Misses        851      861      +10     
Flag Coverage Δ
unittests 69.03% <93.24%> (+1.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RalfG RalfG added the feature Add a new feature label Oct 31, 2024
@RalfG RalfG added this to the v1.2.0 milestone Oct 31, 2024
RalfG added 2 commits November 6, 2024 21:41
- Add support for C-term modifications
- Fixed to-dos
- Formatting and structure
- Add docs
@RalfG RalfG merged commit 133559a into main Nov 6, 2024
4 of 7 checks passed
@RalfG RalfG deleted the diann-io branch November 6, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants