Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make pyOpenMS optional #107

Merged
merged 5 commits into from
Nov 18, 2024
Merged

make pyOpenMS optional #107

merged 5 commits into from
Nov 18, 2024

Conversation

paretje
Copy link
Contributor

@paretje paretje commented Nov 18, 2024

Changed

@paretje paretje force-pushed the feature/optional-pyopenms branch from 5c60600 to c1b0095 Compare November 18, 2024 10:30
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.

Project coverage is 68.98%. Comparing base (133559a) to head (e014823).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
psm_utils/io/idxml.py 55.55% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #107      +/-   ##
==========================================
- Coverage   69.03%   68.98%   -0.06%     
==========================================
  Files          30       30              
  Lines        2781     2789       +8     
==========================================
+ Hits         1920     1924       +4     
- Misses        861      865       +4     
Flag Coverage Δ
unittests 68.98% <55.55%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@paretje paretje requested a review from RalfG November 18, 2024 14:05
@RalfG RalfG modified the milestones: v1.1.0, v1.2.0 Nov 18, 2024
@RalfG RalfG merged commit 414688e into main Nov 18, 2024
5 checks passed
@RalfG RalfG deleted the feature/optional-pyopenms branch November 18, 2024 16:27
RalfG added a commit that referenced this pull request Nov 19, 2024
Remove numpy version pin (should have been part of #107)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants