-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add another implementation of Min #1612
Conversation
supposed to be faster but benchmark show slower: minimum (window size 100): OK (0.32s) |
This is a scan benchmark. Can we also try the fold benchmarks? Also try descending order vs ascending order. We have descending order benchmarks under fold category, we can try the same for postscan as well:
Also, try for smaller window sizes e.g. 10 and 100 sized window. |
for 10,100 size: |
Folds are performing better. |
2d6966b
to
2b3d9db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Fixes:#1591 |
9bfce0e
to
c5e0ee5
Compare
No description provided.