Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Collateral Swap Extension #29

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Add Collateral Swap Extension #29

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
87e5fdd
Add Collataral Swap Extension
sraver Jun 16, 2023
dac4eb1
Add Arbitrum market
sraver Jun 21, 2023
e129994
Update source link
sraver Jun 21, 2023
331e6c7
Update source link to IPFS
sraver Aug 10, 2023
55d5413
Update source link to IPFS
sraver Sep 7, 2023
3a959eb
add transaction permissions
sraver Sep 14, 2023
379291f
Add logs to checkSendTransaction function
barabanovro Sep 28, 2023
b41555a
Fix market token symbols
barabanovro Sep 28, 2023
c72df4f
Add contract addresses to supportedMarkets
barabanovro Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/Extensions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,5 +55,27 @@ export const extensions: Extension[] = [
supportedMarkets: {
'1_USDC_0xc3d688B66703497DAA19211EEdff47f25384cdc3': null
}
},
{
id: 'collateral_swap',
name: 'Collateral Swap',
description: 'Enables swapping collateral on open loan positions without the need to repay the loan, in a single transaction',
developer: 'Wido Labs',
links: {
github: 'https://github.com/widolabs/compound-collateral-extension-ui',
website: 'https://www.joinwido.com/'
},
permissions: {
sign: '*',
},
source: {
url: "https://wido-extension-template.vercel.app/embedded.html"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use an ipfs link instead? See the comet_migrator extension above for an example of how to configure it.

Copy link

@mazurroman mazurroman Jul 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be acceptable to use our backend to serve the "Beta" version, and only deploy the final version to IPFS?

Please let us know if deploying to IPFS even for the Beta launch is necessary and we will do that.

Note: In this post, we proposed the Beta to run for 1 month, in which we would collect feedback. After incorporating the feedback we can launch the final version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just spoke with the team about this and we think using IPFS links is necessary. Even though most third-party devs like yourself that are taking the time to build extensions are probably very trustworthy, we want to remove that layer of trust altogether and make sure that whatever is approved as an extension can't be changed without another set of approvals.

},
supportedMarkets: {
'1_USDC_0xc3d688B66703497DAA19211EEdff47f25384cdc3': null,
'1_WETH_0xA17581A9E3356d9A858b789D68B4d866e593aE94': null,
'137_USDC_0xF25212E676D1F7F89Cd72fFEe66158f541246445': null,
'42161_USDC_0xA5EDBDD9646f8dFF606d7448e414884C7d905dCA': null
}
}
];