address comments

compound-finance · Nov 28, 2023 · 99da5c4 · 99da5c4
1 parent d688672
commit 99da5c4
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/contracts/Comet.sol b/contracts/Comet.sol
@@ -208,23 +208,23 @@ contract Comet is CometMainInterface {
     }
 
     function nonReentrantBefore() internal {
-        bytes32 slot = COMET_REENTRANCY_GUARD_FLAG_SLOT;
+        bytes32 slot = REENTRANCY_GUARD_FLAG_SLOT;
         uint256 status;
         assembly {
             status := sload(slot)
         }
 
-        if (status == COMET_REENTRANCY_GUARD_ENTERED) revert ReentrantCallBlocked();
+        if (status == REENTRANCY_GUARD_ENTERED) revert ReentrantCallBlocked();
         assembly {
-            sstore(slot, COMET_REENTRANCY_GUARD_ENTERED)
+            sstore(slot, REENTRANCY_GUARD_ENTERED)
         }
     }
 
     function nonReentrantAfter() internal {
-        bytes32 slot = COMET_REENTRANCY_GUARD_FLAG_SLOT;
+        bytes32 slot = REENTRANCY_GUARD_FLAG_SLOT;
         uint256 status;
         assembly {
-            sstore(slot, COMET_REENTRANCY_GUARD_NOT_ENTERED)
+            sstore(slot, REENTRANCY_GUARD_NOT_ENTERED)
         }
     }
 
@@ -1320,6 +1320,7 @@ contract Comet is CometMainInterface {
      */
     function approveThis(address manager, address asset, uint amount) override external {
         if (msg.sender != governor) revert Unauthorized();
+
         IERC20NonStandard(asset).approve(manager, amount);
     }
 

diff --git a/contracts/CometCore.sol b/contracts/CometCore.sol
@@ -57,11 +57,11 @@ abstract contract CometCore is CometConfiguration, CometStorage, CometMath {
     uint64 internal constant FACTOR_SCALE = 1e18;
 
     /// @dev The storage slot for reentrancy guard flags
-    bytes32 internal constant COMET_REENTRANCY_GUARD_FLAG_SLOT = bytes32(keccak256("comet.reentrancy.guard"));
+    bytes32 internal constant REENTRANCY_GUARD_FLAG_SLOT = bytes32(keccak256("comet.reentrancy.guard"));
 
-    /// @dev The reentrancy guard status
-    uint256 internal constant COMET_REENTRANCY_GUARD_NOT_ENTERED = 0;
-    uint256 internal constant COMET_REENTRANCY_GUARD_ENTERED = 1;
+    /// @dev The reentrancy guard statuses
+    uint256 internal constant REENTRANCY_GUARD_NOT_ENTERED = 0;
+    uint256 internal constant REENTRANCY_GUARD_ENTERED = 1;
 
     /**
      * @notice Determine if the manager has permission to act on behalf of the owner