Scroll: Remove basefee, ensure scenario tests all run, add migration file #817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -49,7 +49,7 @@ export default async function relayScrollMessage( | |||
|
|
|||
| const aliasAccount = await impersonateAddress( | |||
| bridgeDeploymentManager, | |||
| applyL1ToL2Alias(scrollMessenger.address) | |||
| "0xD69c917c7F1C0a724A51c189B4A8F4F8C8E8cA0a" | |||
There was a problem hiding this comment.
What address is this? Ideally, this will be pulled in from the deployment manager rather than hard-coded, since this file will be used for Scroll mainnet as well.
There was a problem hiding this comment.
For our Goerli testnet, we are using an EOA for this, which is why it's hardcoded, but for mainnet applyL1ToL2Alias(scrollMessenger.address) will be accurate
kevincheng96
reviewed
Nov 8, 2023
deployments/scroll-goerli/usdc/migrations/1694594095_configurate_and_ens.ts
Outdated
Show resolved
Hide resolved
deployments/scroll-goerli/usdc/migrations/1694594095_configurate_and_ens.ts
Outdated
Show resolved
Hide resolved
kevincheng96
added a commit
that referenced
this pull request
Mar 28, 2024
…file (#817) * debug * update price feed * update config * temp workaround * add scroll to scenarios * uncomment spider debug messages * add scroll relations * catch failed spider crawls * Fix spider for scroll * update bridge receiver to be compatible with scroll bridge * update relations * Modified deployment roots from GitHub Actions * remove console.log * rename scroll messenger * add scroll to governance scenarios * adapt scroll relay message fn * fix unit tests * rename contracts and update message relaying * update scroll testnet block explorer URL * remove base fee * fix scroll l2 sender address * remove old roots * fix type errors * Modified deployment roots from GitHub Actions * proposal for intializing usdc market on scroll goerli * add configurator to scroll relations * PR comments --------- Co-authored-by: Isabelle Wei <[email protected]> Co-authored-by: isabelle <[email protected]> Co-authored-by: kevincheng96 <[email protected]> Co-authored-by: GitHub Actions Bot <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.