Address OZ's feedback on USDT comet support#818

Merged

cwang25 merged 36 commits intohans/goerli-usdt-deployfrom hans/goerli-usdt-oz-feedback

Feb 7, 2024

+176-70

Commits on Oct 30, 2023

address L-02
Hans Wang
committed
use ethcall instead of assembly
Hans Wang
committed
using low level call, so won't need IERC20Nonstandard as oppose for ERC20.
Hans Wang
committed

Commits on Nov 8, 2023

add reentrancy guard, and updated tests
Hans Wang
committed
address comments
Hans Wang
committed
inline nonReentrant call
Hans Wang
committed
update on tests
Hans Wang
committed
intent
Hans Wang
committed

Commits on Nov 9, 2023

Commits on Nov 10, 2023

trim down a bit on contract size
Hans Wang
committed
fix tests
Hans Wang
committed
fix lint
Hans Wang
committed

Commits on Nov 13, 2023

use assembly for transfer action, as it save more spaces, and it's already in-use in other contracts
Hans Wang
committed
tests update
Hans Wang
committed

Commits on Nov 14, 2023

Add memory safe assembly
Hans Wang
committed

Commits on Nov 28, 2023

change reentrant to separate functions to reduce space
Hans Wang
committed
address comments
Hans Wang
committed
add memory-safe as recommended in other palces
Hans Wang
committed

Commits on Feb 6, 2024

address comments
Hans Wang
committed
lint
Hans Wang
committed
Update contracts/Comet.sol

cwang25
and
kevincheng96
authored
Update contracts/Comet.sol

cwang25
and
kevincheng96
authored
Update contracts/Comet.sol

cwang25
and
kevincheng96
authored
Update test/buy-collateral-test.ts

cwang25
and
kevincheng96
authored
address more comments
Hans Wang
committed
address comment to let new test to test on buyCollateral attacks specifically
Hans Wang
committed
evil token update
Hans Wang
committed

Commits on Feb 7, 2024

remove accidently checked in test file
Hans Wang
committed
fix last two comments
Hans Wang
committed