Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added strategy to scrape internal transactions #841

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

added strategy to scrape internal transactions #841

wants to merge 3 commits into from

Conversation

peersky
Copy link

@peersky peersky commented Apr 4, 2024

resolves #840

@peersky peersky changed the title added strategy to scrap internal transactions added strategy to scrape internal transactions Apr 4, 2024
kevincheng96
kevincheng96 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@kevincheng96 kevincheng96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. Looks good! Glad to see it fixed your problem because we tried this solution before for Base Sepolia but the internal txn list returned was empty. Might've been something wrong with Etherscan's API.

plugins/import/import.ts Show resolved Hide resolved
plugins/import/import.ts Show resolved Hide resolved
@peersky
Copy link
Author

peersky commented Apr 17, 2024 •
edited
Loading

@kevincheng96 I see that code in main was updated and now does proxy to rpc call for contract creation, however this seem to still be not very stable, im getting scroll rpc endpoint errors:

ProviderError: Too Many Requests error received from rpc.scroll.io

@peersky peersky requested a review from kevincheng96 April 17, 2024 03:51
@peersky peersky mentioned this pull request Apr 19, 2024
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevincheng96 kevincheng96 Awaiting requested review from kevincheng96

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spider tool: fails to crawl create2 contracts produced by internal tx
2 participants
@peersky @kevincheng96