-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewards V2 implementation #843
Open
dmitriy-woof-software
wants to merge
55
commits into
compound-finance:main
Choose a base branch
from
woof-software:woof-software/rewards-v2-multiple-rewards
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rewards V2 implementation #843
dmitriy-woof-software
wants to merge
55
commits into
compound-finance:main
from
woof-software:woof-software/rewards-v2-multiple-rewards
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Preliminary CometRewardsV2 functionality with MerkleProof * feat: restructorized contract storage, fixed all compilaion errors * fix: multiple assets compaign * fix: compaigns functionality * feat: Add finishAccrued and startAccrued bug fix * feat: claimed calculation fix * feat: claimed calculation fix * feat: add CometRewards V1 interaction * wip: tests and new contract version * wip: contract update with more tests * wip: new contract update and revert changes to CometRewards * wip: cover most of the contract and fix some bugs * wip: coverage improvement * feat: complited contract changes and test coverage * feat: remove package-lock * feat: set yarn file to the main branch version * feat: update yarn file
…are/rewards-v2-multiple-rewards
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semgrep OSS found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
…rkle-tree-generation-script
…are/rewards-v2-multiple-rewards
… of github.com:woof-software/comet into woof-software/rewards-v2-multiple-rewards
…are/rewards-v2-multiple-rewards
…m:woof-software/comet into woof-software/rewards-v2-multiple-rewards
…ithub.com/woof-software/comet into woof-software/rewards-v2-multiple-rewards
…are/rewards-v2-multiple-rewards
…m:woof-software/comet into woof-software/rewards-v2-multiple-rewards
…ithub.com/woof-software/comet into woof-software/rewards-v2-multiple-rewards
…m:woof-software/comet into woof-software/rewards-v2-multiple-rewards
…tware/comet into woof-software/rewards-v2-multiple-rewards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary CometRewardsV2 functionality with MerkleProof
feat: restructorized contract storage, fixed all compilaion errors
fix: multiple assets compaign
fix: compaigns functionality
feat: Add finishAccrued and startAccrued bug fix
feat: claimed calculation fix
feat: claimed calculation fix
feat: add CometRewards V1 interaction
wip: tests and new contract version
wip: contract update with more tests
wip: new contract update and revert changes to CometRewards
wip: cover most of the contract and fix some bugs
wip: coverage improvement
feat: complited contract changes and test coverage
feat: remove package-lock
feat: set yarn file to the main branch version
feat: update yarn file