Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set callback slot to 0 before executing script #221

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

kevincheng96
Copy link
Collaborator

We need to set the callback slot to 0 before executing a script to ensure that nested operations don't inherit the callback value of the parent operation.

@kevincheng96 kevincheng96 requested review from fluffywaffles and hayesgm and removed request for fluffywaffles September 27, 2024 01:04
Copy link
Collaborator

@fluffywaffles fluffywaffles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nested ops are weird, but reasonable approximation of the callback flow

@kevincheng96 kevincheng96 merged commit 0123c18 into kevin/quark-v2 Sep 30, 2024
4 checks passed
@kevincheng96 kevincheng96 deleted the kevin/tstore-callback branch September 30, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants