Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise form with react-hook-form #10

Merged
merged 7 commits into from
Jan 15, 2024

Conversation

jsun969
Copy link
Member

@jsun969 jsun969 commented Jan 13, 2024

Hi there, I'm new to the uni and the club.

I found you are using zod to validate form so I installed react-hook-form to optimise the code which makes the code cleaner and easier to maintain.

join-us & forgot-password can also be optimised. (which is a huge work XD) In that way, Form will not need so many props to set and get state. If you want to do that, please feel free to tell me. I'll be happy to help!

cc @phoenixpereira @rishiad

@jsun969
Copy link
Member Author

jsun969 commented Jan 15, 2024

need a githook for prettier?

@jsun969
Copy link
Member Author

jsun969 commented Jan 15, 2024

run pnpm i again to enable git hook

Copy link
Member

@phoenixpereira phoenixpereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rishiad
Copy link
Contributor

rishiad commented Jan 15, 2024

LGTM

@rayokamoto rayokamoto merged commit 35cab0e into compsci-adl:account-system Jan 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants