Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise forgot-password and join-us form #11

Merged
merged 18 commits into from
Jan 18, 2024
Merged

Optimise forgot-password and join-us form #11

merged 18 commits into from
Jan 18, 2024

Conversation

jsun969
Copy link
Member

@jsun969 jsun969 commented Jan 15, 2024 •
edited
Loading

  1. Refactored forgot-password and join-us forms by using react-hook-form.
  2. Control join-us steps & data by using zustand.
  3. Added a helper for handling clerk errors.
  4. Removed a lot of unnecessary code.
  5. Left a todo in step 4 to integrate payment and database (provided all user data in a super ez and type-safe way XD)

@jsun969 jsun969 marked this pull request as ready for review January 17, 2024 09:52
@jsun969 jsun969 changed the title [WIP] Optimise forgot-password and join-us form Optimise forgot-password and join-us form Jan 17, 2024
@phoenixpereira phoenixpereira added the refactor Changes to code structure with no changes to logic label Jan 17, 2024
rayokamoto
rayokamoto requested changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@rayokamoto rayokamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, I'd say you've done a great job with the refactoring. There are a few things to follow up on - some being questions and other things I want changed or to open up further discussion.

src/app/(account)/forgot-password/page.tsx Outdated Show resolved Hide resolved
src/app/(account)/join-us/ProgressBar.tsx Show resolved Hide resolved
src/app/(account)/join-us/steps/StepOne.tsx Outdated Show resolved Hide resolved
src/app/(account)/join-us/steps/StepOne.tsx Outdated Show resolved Hide resolved
src/app/(account)/join-us/steps/StepThree.tsx Outdated Show resolved Hide resolved
src/app/(account)/schemas.ts Outdated Show resolved Hide resolved
src/app/(account)/schemas.ts Outdated Show resolved Hide resolved
@jsun969 jsun969 requested a review from rayokamoto January 18, 2024 05:18
@rayokamoto rayokamoto merged commit 5234f90 into compsci-adl:account-system Jan 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayokamoto rayokamoto rayokamoto approved these changes

@phoenixpereira phoenixpereira Awaiting requested review from phoenixpereira

@rishiad rishiad Awaiting requested review from rishiad

Assignees
No one assigned
Labels
refactor Changes to code structure with no changes to logic
Projects
Website
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsun969 @rayokamoto @phoenixpereira