Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update tech stacks in open source page #169

Closed
wants to merge 10 commits into from

Conversation

KnightRadiant44
Copy link
Collaborator

@KnightRadiant44 KnightRadiant44 commented Aug 4, 2024

Description

Update few tech stacks on open source page

Changes Made

Updated the requested tech stacks.

Related Issues

resolve #168

Additional Notes

image

Copy link
Member

@jsun969 jsun969 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the changes in bump.rdb package.json pnpm-lock.yaml

And the tech stack is incorrect from the issue

@jsun969 jsun969 changed the title Add techstack feat: Add techstack Aug 4, 2024
@jsun969 jsun969 changed the title feat: Add techstack feat: Update tech stacks in open source page Aug 4, 2024
@phoenixpereira
Copy link
Member

@KnightRadiant44 The build fails because pnpm-lock.yaml is different, so you have to revert the changes done to it to make it work.

@KnightRadiant44
Copy link
Collaborator Author

I'll try to revert the changes again after a while

@phoenixpereira
Copy link
Member

@KnightRadiant44 Try running pnpm format since there seems to be some formatting issues in your code. It's not picked up in the formatting check for some reason 🤷‍♂️.

@KnightRadiant44
Copy link
Collaborator Author

I will close this pull request and try to resolve this issue first. I am not sure where exactly it is going wrong.

@rayokamoto
Copy link
Contributor

Did you run prettier formatting via VS Code? pnpm format shouldn't have changed all those files... I was going to suggest closing and redoing the PR but looks like you've already closed it.

In future, make sure to check what files have been changed (git status) and only add and commit relevant files to avoid adding things you don't want to add. I also suggest reading the contributing guidelines for some guidance with formatting and linting, as well as the conventions this project uses for commit messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

[Feature Request] Update tech stack on open source page
4 participants