Add backend #37
Merged
Add backend #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayokamoto
reviewed
Jan 23, 2024
src/constants/student-info.ts
Outdated
There was a problem hiding this comment.
Could we maybe have a newline to separate out each of the constants?
src/db/schema.ts
Outdated
|
|
||
| emailPreferences: text('email_preferences', { mode: 'json' }), | ||
|
|
||
| membershipExpiredAt: integer('membership_expired_at', { mode: 'timestamp' }), |
There was a problem hiding this comment.
Change to membershipExpiresAt and membership_expires_at as membership could still be ongoing (it doesn't really make sense to say "expired" if it hasn't, if you get what I mean).
There was a problem hiding this comment.
I really need to learn more English 🤣
rayokamoto
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add backend
Changes Made
Related Issues
close #18
Additional Notes
Read the updated readme and env example to initialize database first.