Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Rename all images to dash-case #39

Merged
merged 2 commits into from
Jan 24, 2024
Merged

Conversation

jsun969
Copy link
Member

@jsun969 jsun969 commented Jan 24, 2024

Description

Rename all image filenames to dash-case

Changes Made

  • Rename image filenames to dash-case
  • Create /home folder for homepage images

Related Issues

N/A

Additional Notes

If using camelCase for image filename

// Same
<Image src="/image/compsciAdl" />
<Image src="/image/compsciadl" />

There will be uncertainty

Also, git has a problem with file name case. It is recommend to use dash-case for filename.

@jsun969 jsun969 added enhancement frontend refactor Changes to code structure with no changes to logic labels Jan 24, 2024
Copy link
Contributor

@rayokamoto rayokamoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we put logos under public/images/logos?

@rayokamoto
Copy link
Contributor

rayokamoto commented Jan 24, 2024

I agree with the changes that with PR aims to address. It's definitely better generally to have lowercase and use dashes so that it is URL-friendly as well.

Also, git has a problem with file name case. It is recommend to use dash-case for filename.

Yeah, files names in macOS and Windows are case-insensitive to if there are two files that are only differentiated by uppercase/lowercase then things are bound to go wrong.

@rayokamoto rayokamoto merged commit 43fcd97 into main Jan 24, 2024
2 checks passed
@rayokamoto rayokamoto deleted the refactor/image-folder branch January 24, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement frontend refactor Changes to code structure with no changes to logic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants