fix(header): mobile menu has correct links and behaviour #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
phoenixpereira
pushed a commit
that referenced
this pull request
Feb 24, 2024
rayokamoto
added a commit
that referenced
this pull request
Feb 24, 2024
* chore: remove extra margin on join us page * feat: make account boxes fit better on mobile * refactor: simplify bool component props and rename isFormButton to size * feat(home): Add join us button at end of page * fix(home): Center sponsors on screen resize * feat(home): Use join us link instead of button * chore: spelling and grammar fixes (#86) * chore: more spelling and grammar fixes (#88) * feat: add button loading to indicate request in progress (#89) * chore: add loading for pay online button (#92) * feat: enable ssr for header * feat(api): remove unnecessary apis * feat: refresh rsc after mutation (#94) * feat: add titles for all pages * feat(seo): disable robot for few pages * fix(seo): remove metadata on client components * fix(header): mobile menu has correct links and behaviour (#96) * chore: Add underline styling to mobile menu links (#98) * fix(contact): minor fix for mobile style (#100) * fix: make button component valid after merge * chore: use self-closing tag for divs * chore: make settings container wider on desktop * fix(settings): responsive style for setting tabs --------- Co-authored-by: Ray <[email protected]> Co-authored-by: Timothy Choi <[email protected]> Co-authored-by: jsun969 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During the header refactor, the mobile menu had a few bugs such as not having any login links.
Changes Made