Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add underline styling to mobile menu links #98

Merged
merged 1 commit into from
Feb 19, 2024
+20 −5
Merged

chore: Add underline styling to mobile menu links #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/components/Header/HeaderMobileClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,9 +95,18 @@ export default function HeaderMobileClient({
<MenuLinks data={data} onClick={closeMenu} />

{/* Links for sign up, sign in, sign out */}
{!data.isSignedIn && <SignInJoinMobile onClick={closeMenu} />}
{!data.isSignedIn && (
<SignInJoinMobile
className="block hover:underline"
onClick={closeMenu}
/>
)}
{data.isSignedIn && (
<Link href="/" onClick={handleSignOut}>
<Link
href="/"
className="block hover:underline"
onClick={handleSignOut}
>
Sign Out
</Link>
)}
Expand Down
12 changes: 9 additions & 3 deletions src/components/Header/components/SignInJoin.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,19 @@ export function SignInJoin() {
);
}

export function SignInJoinMobile({ onClick }: { onClick?: () => void }) {
export function SignInJoinMobile({
className,
onClick,
}: {
className: string;
onClick?: () => void;
}) {
return (
<>
<Link onClick={onClick} href="/signin">
<Link onClick={onClick} className={className} href="/signin">
Sign In
</Link>
<Link onClick={onClick} href="/join">
<Link onClick={onClick} className={className} href="/join">
Join Us
</Link>
</>
Expand Down
Loading