Tried to modify key current of an object which has been already passed to a worklet #551
+26
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would be great to get this in at some point @computerjazz :) Confirmed to work in our app. |
48 tasks
|
@computerjazz please? |
|
I'm also running into this issue and it would be great to have the fix in soon :) |
jefferyjxn
approved these changes
Oct 30, 2024
|
@elliottkember would you please update the PR with the latest patch from #539 to resolve the warnings? |
|
@computerjazz please 🙏 |
|
@ddrozdov Done – thank you for your help! Please double-check that it all looks good. And if you have further changes feel free to make a PR on my fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hit the error in #539 when using this library. The patch suggested in the issue has solved the problem for me.
Closes #539