Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sail: Enable jpegxl #25806

Merged
merged 4 commits into from
Nov 4, 2024
Merged

sail: Enable jpegxl #25806

merged 4 commits into from
Nov 4, 2024

Conversation

HappySeaFox
Copy link
Contributor

@HappySeaFox HappySeaFox commented Nov 3, 2024

Summary

Changes to recipe: sail/*

Motivation

Enable JPEGXL as it's now available in Conan. 0.8.2 version is used as 0.10.x fails to compile. The issue needs to be fixed on the SAIL side later.

Details

Should close #25575

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

Failure in build 2 (9c2adc734602f1044ec79f831eee9116ec18643c):

  • sail/0.9.6:
    Didn't run or was cancelled before finishing

  • sail/0.9.4:
    Didn't run or was cancelled before finishing

  • sail/0.9.5:
    CI failed to create some packages (All logs)

    Logs for packageID 5ef344e5c42b89ff1a48c0def5f6d0c0c0b0eeaa:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=9
    os=Linux
    [options]
    sail:shared=True
    
    [...]
    resizable_parallel_runner.cc:(.text+0x494): undefined reference to `operator new(unsigned long)'
    /usr/bin/ld: resizable_parallel_runner.cc:(.text+0x4ac): undefined reference to `std::condition_variable::condition_variable()'
    /usr/bin/ld: resizable_parallel_runner.cc:(.text+0x4b6): undefined reference to `std::condition_variable::condition_variable()'
    /usr/bin/ld: /home/conan/workspace/prod-v1/bsr/117224/defdc/.conan/data/libjxl/0.8.2/_/_/package/6e474dea1c283b2f4e4060d5625de96000f600ef/lib/libjxl_threads.a(resizable_parallel_runner.cc.o): in function `JxlResizableParallelRunnerSuggestThreads':
    resizable_parallel_runner.cc:(.text+0x546): undefined reference to `std::thread::hardware_concurrency()'
    /usr/bin/ld: /home/conan/workspace/prod-v1/bsr/117224/defdc/.conan/data/libjxl/0.8.2/_/_/package/6e474dea1c283b2f4e4060d5625de96000f600ef/lib/libjxl_threads.a(resizable_parallel_runner.cc.o): in function `JxlResizableParallelRunnerDestroy':
    resizable_parallel_runner.cc:(.text+0x5ad): undefined reference to `std::condition_variable::notify_all()'
    /usr/bin/ld: resizable_parallel_runner.cc:(.text+0x5d9): undefined reference to `std::thread::join()'
    /usr/bin/ld: resizable_parallel_runner.cc:(.text+0x604): undefined reference to `operator delete(void*)'
    /usr/bin/ld: resizable_parallel_runner.cc:(.text+0x60e): undefined reference to `std::condition_variable::~condition_variable()'
    /usr/bin/ld: resizable_parallel_runner.cc:(.text+0x616): undefined reference to `std::condition_variable::~condition_variable()'
    /usr/bin/ld: resizable_parallel_runner.cc:(.text+0x664): undefined reference to `std::__throw_system_error(int)'
    /usr/bin/ld: resizable_parallel_runner.cc:(.text+0x671): undefined reference to `std::terminate()'
    /usr/bin/ld: /home/conan/workspace/prod-v1/bsr/117224/defdc/.conan/data/libjxl/0.8.2/_/_/package/6e474dea1c283b2f4e4060d5625de96000f600ef/lib/libjxl_threads.a(resizable_parallel_runner.cc.o): in function `JxlResizableParallelRunnerSetThreads':
    resizable_parallel_runner.cc:(.text+0x6dd): undefined reference to `std::condition_variable::notify_all()'
    /usr/bin/ld: resizable_parallel_runner.cc:(.text+0x721): undefined reference to `std::thread::join()'
    /usr/bin/ld: resizable_parallel_runner.cc:(.text+0x7a5): undefined reference to `operator new(unsigned long)'
    /usr/bin/ld: resizable_parallel_runner.cc:(.text+0x7ce): undefined reference to `std::thread::_M_start_thread(std::unique_ptr<std::thread::_State, std::default_delete<std::thread::_State> >, void (*)())'
    /usr/bin/ld: resizable_parallel_runner.cc:(.text+0x850): undefined reference to `operator new(unsigned long)'
    /usr/bin/ld: resizable_parallel_runner.cc:(.text+0x886): undefined reference to `operator new(unsigned long)'
    /usr/bin/ld: resizable_parallel_runner.cc:(.text+0x8b3): undefined reference to `std::thread::_M_start_thread(std::unique_ptr<std::thread::_State, std::default_delete<std::thread::_State> >, void (*)())'
    /usr/bin/ld: resizable_parallel_runner.cc:(.text+0x923): undefined reference to `operator delete(void*)'
    /usr/bin/ld: resizable_parallel_runner.cc:(.text+0x9b2): undefined reference to `std::terminate()'
    /usr/bin/ld: resizable_parallel_runner.cc:(.text+0x9be): undefined reference to `std::__throw_length_error(char const*)'
    /usr/bin/ld: resizable_parallel_runner.cc:(.text+0x9ca): undefined reference to `std::__throw_system_error(int)'
    /usr/bin/ld: /home/conan/workspace/prod-v1/bsr/117224/defdc/.conan/data/libjxl/0.8.2/_/_/package/6e474dea1c283b2f4e4060d5625de96000f600ef/lib/libjxl_threads.a(resizable_parallel_runner.cc.o): in function `std::thread::_State_impl<std::thread::_Invoker<std::tuple<jpegxl::(anonymous namespace)::ResizeableParallelRunner::SetNumThreads(unsigned long)::{lambda()#1}> > >::~_State_impl()':
    resizable_parallel_runner.cc:(.text+0xf): undefined reference to `std::thread::_State::~_State()'
    /usr/bin/ld: /home/conan/workspace/prod-v1/bsr/117224/defdc/.conan/data/libjxl/0.8.2/_/_/package/6e474dea1c283b2f4e4060d5625de96000f600ef/lib/libjxl_threads.a(resizable_parallel_runner.cc.o): in function `std::thread::_State_impl<std::thread::_Invoker<std::tuple<jpegxl::(anonymous namespace)::ResizeableParallelRunner::SetNumThreads(unsigned long)::{lambda()#1}> > >::~_State_impl()':
    resizable_parallel_runner.cc:(.text+0x50): undefined reference to `operator delete(void*, unsigned long)'
    /usr/bin/ld: /home/conan/workspace/prod-v1/bsr/117224/defdc/.conan/data/libjxl/0.8.2/_/_/package/6e474dea1c283b2f4e4060d5625de96000f600ef/lib/libjxl_threads.a(resizable_parallel_runner.cc.o): in function `JxlResizableParallelRunnerDestroy':
    resizable_parallel_runner.cc:(.text+0x62d): undefined reference to `operator delete(void*, unsigned long)'
    /usr/bin/ld: /home/conan/workspace/prod-v1/bsr/117224/defdc/.conan/data/libjxl/0.8.2/_/_/package/6e474dea1c283b2f4e4060d5625de96000f600ef/lib/libjxl_threads.a(resizable_parallel_runner.cc.o): in function `std::vector<std::thread, std::allocator<std::thread> >::_M_default_append(unsigned long)':
    resizable_parallel_runner.cc:(.text._ZNSt6vectorISt6threadSaIS0_EE17_M_default_appendEm[_ZNSt6vectorISt6threadSaIS0_EE17_M_default_appendEm]+0xbd): undefined reference to `operator new(unsigned long)'
    /usr/bin/ld: resizable_parallel_runner.cc:(.text._ZNSt6vectorISt6threadSaIS0_EE17_M_default_appendEm[_ZNSt6vectorISt6threadSaIS0_EE17_M_default_appendEm]+0x120): undefined reference to `operator delete(void*)'
    /usr/bin/ld: resizable_parallel_runner.cc:(.text._ZNSt6vectorISt6threadSaIS0_EE17_M_default_appendEm[_ZNSt6vectorISt6threadSaIS0_EE17_M_default_appendEm]+0x157): undefined reference to `std::__throw_length_error(char const*)'
    collect2: error: ld returned 1 exit status
    make[2]: *** [src/sail-codecs-archive/CMakeFiles/sail-codecs.dir/build.make:222: src/sail-codecs-archive/libsail-codecs.so] Error 1
    make[1]: *** [CMakeFiles/Makefile2:1175: src/sail-codecs-archive/CMakeFiles/sail-codecs.dir/all] Error 2
    make: *** [Makefile:149: all] Error 2
    WARN: **************************************************
    WARN: *** Conan 1 is legacy and on a deprecation path **
    WARN: *********** Please upgrade to Conan 2 ************
    WARN: **************************************************
    sail/0.9.5: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    sail/0.9.5: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    sail/0.9.5: ERROR: Package '5ef344e5c42b89ff1a48c0def5f6d0c0c0b0eeaa' build failed
    sail/0.9.5: WARN: Build folder /home/conan/workspace/prod-v1/bsr/117224/defdc/.conan/data/sail/0.9.5/_/_/build/5ef344e5c42b89ff1a48c0def5f6d0c0c0b0eeaa/build/Release
    ERROR: sail/0.9.5: Error in build() method, line 118
    	cmake.build()
    	ConanException: Error 2 while executing cmake --build "/home/conan/workspace/prod-v1/bsr/117224/defdc/.conan/data/sail/0.9.5/_/_/build/5ef344e5c42b89ff1a48c0def5f6d0c0c0b0eeaa/build/Release" '--' '-j3'
    
  • sail/0.9.1:
    Didn't run or was cancelled before finishing

  • sail/0.9.0:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@jcar87 jcar87 self-assigned this Nov 4, 2024
Copy link
Member

@AbrilRBS AbrilRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jcar87 jcar87 merged commit 0ab91ca into conan-io:master Nov 4, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants