Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sail: fix Windows/Clang build #25480

Closed
wants to merge 1 commit into from
Closed

Conversation

dutow
Copy link

@dutow dutow commented Oct 1, 2024

Summary

Changes to recipe: sail/*

Motivation

With the current recipe, debug builds fail with Clang on Windows because a MSVC specific condition.

Details

Fix: also handle clang in that condition.


With the current recipe, debug builds fail with Clang on Windows
because a MSVC specific condition.

Fix: also handle clang in that condition.
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Warning

Conan Center will stop receiving updates for Conan 1.x packages soon - please see announcement.

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

Sorry, the build is only launched for Access Request users. You can request access writing in this issue.

@jcar87
Copy link
Contributor

jcar87 commented Nov 4, 2024

Thanks @dutow - making that line unconditional in #25806, as it shouldn't have adverse effects on any compiler/platform. Closing this as the intended fix should already be part of 25806

@jcar87 jcar87 closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants