Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restbed: add restbed/4.8 recipe #13561

Merged
merged 14 commits into from
Oct 22, 2022
Merged

restbed: add restbed/4.8 recipe #13561

merged 14 commits into from
Oct 22, 2022

Conversation

madebr
Copy link
Contributor

@madebr madebr commented Oct 17, 2022 •
edited
Loading

Specify library name and version: restbed/4.8

Tested with MSVC2019, gcc@Linux, mingw@Linux

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Oct 18, 2022
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions
Copy link
Contributor

Hooks produced the following warnings for commit 6b17cd5
restbed/4.8 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './lib/librestbed.so' links to system library 'm' but it is not in cpp_info.system_libs.

@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
uilianries
uilianries previously approved these changes Oct 20, 2022
View reviewed changes
jwillikers
jwillikers suggested changes Oct 20, 2022
View reviewed changes
recipes/restbed/all/conanfile.py Outdated Show resolved Hide resolved
recipes/restbed/all/conanfile.py Outdated Show resolved Hide resolved
recipes/restbed/all/conanfile.py Outdated Show resolved Hide resolved
recipes/restbed/all/conanfile.py Outdated Show resolved Hide resolved
recipes/restbed/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/restbed/all/test_package/CMakeLists.txt Show resolved Hide resolved
recipes/restbed/all/test_package/CMakeLists.txt Outdated Show resolved Hide resolved
recipes/restbed/all/test_package/test_package.cpp Outdated Show resolved Hide resolved
recipes/restbed/all/test_v1_package/CMakeLists.txt Show resolved Hide resolved
recipes/restbed/all/test_v1_package/CMakeLists.txt Outdated Show resolved Hide resolved
jwillikers
jwillikers previously approved these changes Oct 20, 2022
View reviewed changes
@conan-center-bot

This comment has been minimized.

Sign in to view
jwillikers
jwillikers previously approved these changes Oct 21, 2022
View reviewed changes
@conan-center-bot

This comment has been minimized.

Sign in to view
prince-chrismc
prince-chrismc reviewed Oct 22, 2022
View reviewed changes
Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit about license, otherwise it's good

@conan-center-bot
Copy link
Collaborator

All green in build 16 (c43a129deac171521d4b522ca213ffee429c282b):

  • restbed/4.8@:
    All packages built successfully! (All logs)

@madebr madebr mentioned this pull request Oct 22, 2022
Closed
@conan-center-bot conan-center-bot merged commit 075c614 into conan-io:master Oct 22, 2022
@madebr madebr deleted the restbed-recipe branch October 22, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SpaceIm SpaceIm SpaceIm left review comments

@toge toge toge left review comments

@jwillikers jwillikers jwillikers approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@uilianries uilianries uilianries left review comments

@danimtb danimtb Awaiting requested review from danimtb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@madebr @conan-center-bot @toge @uilianries @prince-chrismc @jwillikers @SpaceIm